Skip to content

Conversation

@lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Dec 24, 2025

This PR refactors linux_tags function by reducing* the cases in that function by using distribution instead of hardcoded distribution names. (330b515)

It also removes duplicated debian_variants function, and uses new is_<distribution> functions in the platforms one for readability.

*: a bit, there are still inconsistencies between distribution tags that need to be taken care of.

Amends:

Testing done

make test

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@lemeurherve lemeurherve requested a review from a team as a code owner December 24, 2025 19:10
@lemeurherve lemeurherve force-pushed the docker-bake-improvements branch 10 times, most recently from f9e20a4 to cdfaa67 Compare December 24, 2025 23:33
@lemeurherve lemeurherve marked this pull request as draft December 25, 2025 17:27
@lemeurherve

This comment was marked as resolved.

@lemeurherve lemeurherve force-pushed the docker-bake-improvements branch from cdfaa67 to 330b515 Compare December 25, 2025 18:43
@lemeurherve lemeurherve force-pushed the docker-bake-improvements branch from 330b515 to d3bc3f2 Compare December 26, 2025 16:17
@lemeurherve lemeurherve marked this pull request as ready for review December 26, 2025 16:17
@lemeurherve lemeurherve merged commit 5862257 into jenkinsci:master Dec 28, 2025
12 checks passed
@lemeurherve lemeurherve deleted the docker-bake-improvements branch December 28, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants