chore(updatecli): track JDK21 version in Dockerfiles#2337
Merged
Conversation
6 tasks
dduportal
approved these changes
May 11, 2026
Contributor
dduportal
left a comment
There was a problem hiding this comment.
LGTM! the CI checks shows the new targets will update the expected ARG values:
target: setJDK21Version
-----------------------
Repository : github.com/jenkinsci/docker@master
[transformers]
✔ Result correctly transformed from "21.0.11+10" to "21.0.11_10"
⚠ The line #5, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21.0.10_7" to "ARG JAVA_VERSION=21.0.11_10".
⚠ The line #8, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21.0.10_7" to "ARG JAVA_VERSION=21.0.11_10".
⚠ The line #5, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21.0.10_7" to "ARG JAVA_VERSION=21.0.11_10".
⚠ The line #4, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21.0.10_7" to "ARG JAVA_VERSION=21.0.11_10".
⚠ The line #12, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21.0.10_7" to "ARG JAVA_VERSION=21.0.11_10".
⚠ - changed lines [5] of file "alpine/hotspot/Dockerfile", changed lines [8] of file "debian/Dockerfile", changed lines [5] of file "rhel/Dockerfile", changed lines [4 12] of file "windows/windowsservercore/hotspot/Dockerfile"
and no regression on the existing target:
target: setJDK21VersionDockerBake
---------------------------------
Repository : github.com/jenkinsci/docker@master
[transformers]
✔ Result correctly transformed from "21.0.11+10" to "21.0.11_10"
✔ - no changes detected:
path "variable.JAVA21_VERSION.default" already set to "21.0.11_10", from file "docker-bake.hcl",
Contributor
|
FTR, updated title and labels:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes restores the target updating all Dockerfiles for the main JDK (21).
Ref:
Testing done
CI
Submitter checklist