Fixed ambiguous ls-remote with refs/heads/...

[alexanderlink]

This is the smallest possible change to solve the
issue of CI builds being triggered again and again.
ls-remote will always be definite when "refs/heads/"
is used as branchSpec (except if branch names start with "refs/heads/" which no one should do - but could).

I wrote down my findings and thoughts here:
https://github.com/alexanderlink/git-plugin/tree/branchSpecDiscussion

All other issues tried to solve with Pull Request
#129
are still open. But using refs/heads/ would already solve
the CI issue.

[cloudbees-pull-request-builder]

plugins » git-client-plugin #470 ABORTED

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[cloudbees-pull-request-builder]

plugins » git-client-plugin #471 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

plugins » git-client-plugin #472 SUCCESS
This pull request looks good

[cloudbees-pull-request-builder]

plugins » git-client-plugin #473 SUCCESS
This pull request looks good

[alexanderlink]

Hi Mark,

I added some integration tests to the git plugin verifying the changes in this (git-client plugin) pull request.
jenkinsci/git-plugin#232

Kind regards,
Alex

[rggjan]

Any updates on this? I'm waiting for this to be fixed really badly...

[alexanderlink]

@MarkEWaite any update? We're also waiting for this fix. Sooner or later we will get trouble (I already thought about releasing a patch internally).

[MarkEWaite]

I just released 1.9.2 and set the next version to be 1.10.0, preparing for this change and one other change. I spent several hours experimenting with the change last weekend but did not complete enough testing to be confident to release it.

I hope to release 1.10.0 with this fix and 1-2 others within the next 1-2 weeks.

[MarkEWaite]

This change has been merged into git-client-plugin prior to the release of 1.10.0.

[alexanderlink]

I added feedback regarding #135 and open issues:
https://github.com/alexanderlink/git-plugin/tree/branchSpecDiscussion

I closed #129 because it became too complex, but maybe we should continue to try solving the remaining issues.

[MarkEWaite]

I'm not clear that we can do much more without breaking compatibility with existing behavior. The existing behavior is flawed (ignoring everything to the left of the rightmost "/" character in the "Branches to build" value unless refs/heads is used), but I think there are too many use cases which will break if we improve the behavior for those old cases.

I think it would be very nice to include help text in the "Branches to build" field of the git plugin which describes the use of refs/heads as a way to unambiguously specify a branch to build.

[alexanderlink]

Hi Mark,

I adjusted the help: jenkinsci/git-plugin#244
Is it OK like this?

Thanks and regards,
Alex