[JENKINS-34309] Only parse reasonable branch line output#213
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Jul 12, 2016
Merged
Conversation
Avoid string index out of bounds exception on unexpected output from "git branch -v --no-abbrev" (as reported in JENKINS-34309). The JENKINS-34309 issue may be related to gitlab bug 14453 https://gitlab.com/gitlab-org/gitlab-ce/issues/14453 Added a test to check that empty repo reports no branches. Empty repo does not show the problem which was detected in JENKINS-34309. My attempts to duplicate JENKINS-34309 in an automated test have all failed. Those attempts are included in this commit (though unsuccessful at duplicating the problem).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid string index out of bounds exception on unexpected output from
"git branch -v --no-abbrev" (as reported in JENKINS-34309).
The JENKINS-34309 issue may be related to gitlab bug 14453
https://gitlab.com/gitlab-org/gitlab-ce/issues/14453
Added a test to check that empty repo reports no branches. Empty
repo does not show the problem which was detected in JENKINS-34309.
My attempts to duplicate JENKINS-34309 in an automated test have all
failed. Those attempts are included in this commit (though unsuccessful
at duplicating the problem).