JGit improvements from Christian Halstrick review #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
changed the title
MarkEWaite
changed the title
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
4 times, most recently
from
143f4ca to
1c79596
Compare
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
2 times, most recently
from
8950fbd to
2f2db17
Compare
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
7 times, most recently
from
3d56fbb to
7352bf2
Compare
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
from
7352bf2 to
4c5fd6b
Compare
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
5 times, most recently
from
8ddabe9 to
48c707b
Compare
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
from
48c707b to
a747dd7
Compare
The JGit implementation has deprecated getRef and replaced it with two implementations, one for exactRef() and one for findRef(). In this case, the ref is being formed into an exact reference, so the exactRef() call is the correct choice.
Remove redundant check for null ref in branch checkout Also rename doCheckout methods to more clearly say what they do. Add null ref check to tests
Reduce unnecessary reimplementation of LsRemoteCommand in the JGitAPIImpl source code.
MarkEWaite
force-pushed
the
jgit-improvements-with-christian-halstrick
branch
from
a747dd7 to
2794867
Compare
Wadeck
approved these changes
Apr 24, 2018
Wadeck
left a comment
Wadeck
left a comment
There was a problem hiding this comment.
🐝 Even without lots of knowledge in that area, the changes seem to be reasonnable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Christian Halstrick of the JGit project sat with me for a day at the Jenkins Hackfest after FOSDEM. We reviewed the JGit implementation and made improvements while capturing action items.
@reviewbybees