Weaken the type requirement on the instanceof used in the git-client plu...#32
Merged
ndeloof merged 1 commit intojenkinsci:masterfrom Oct 29, 2013
mattmoor:master
Merged
Weaken the type requirement on the instanceof used in the git-client plu...#32ndeloof merged 1 commit intojenkinsci:masterfrom mattmoor:master
ndeloof merged 1 commit intojenkinsci:masterfrom
mattmoor:master
Conversation
…plugin to only rely on the object being a StandardUsernamePasswordCredentials. The interface is both necessary and sufficient for the APIs used. This is morally equivalent to how the private key logic is already using the SSHUserPrivateKey interface vs. a specific implementation.
|
plugins » git-client-plugin #137 SUCCESS |
Member
|
Looks right to me. @stephenc do you want to check this? |
ndeloof
added a commit
that referenced
this pull request
Oct 29, 2013
Weaken the type requirement on the instanceof used in the git-client plu...
Member
mattmoor
added a commit
to mattmoor/git-client-plugin
that referenced
this pull request
Feb 20, 2014
…entials/ NOTE: This is the same change that I had made previously in this pull request: jenkinsci#32 I am not sure how or why my "merged" pull request does not appear in the commit history of the repo. The original notes from PR#32 follow: Weaken the type requirement on the instanceof used in the git-client plugin to only rely on the object being a StandardUsernamePasswordCredentials. The interface is both necessary and sufficient for the APIs used. This is morally equivalent to how the private key logic is already using the SSHUserPrivateKey interface vs. a specific implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...gin to only rely on the object being a StandardUsernamePasswordCredentials.
The interface is both necessary and sufficient for the APIs used.
This is morally equivalent to how the private key logic is already using the SSHUserPrivateKey interface vs. a specific implementation.