Skip to content

fix workDir for gitcredentials#90

Closed
kapcsandi wants to merge 2 commits intojenkinsci:masterfrom
kapcsandi:master
Closed

fix workDir for gitcredentials#90
kapcsandi wants to merge 2 commits intojenkinsci:masterfrom
kapcsandi:master

Conversation

@kapcsandi
Copy link

Possible fix for https://issues.jenkins-ci.org/browse/JENKINS-21016 in unix environment.

@cloudbees-pull-request-builder

plugins » git-client-plugin #268 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

plugins » git-client-plugin #269 SUCCESS
This pull request looks good

@kapcsandi
Copy link
Author

I have to learn more about jenkins and plugins to write such test. This fix is pretty dumb because it assume that .git/config exist in jenkins' home.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ndeloof
Copy link
Contributor

ndeloof commented Jan 30, 2014

Don't use $HOME here, but only build-related directories (ie $WORKSPACE) so that same build slave can run concurrent builds / git commands without conflicts.

@ndeloof ndeloof closed this Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants