[JENKINS-66296] Avoid unexpected polling rebuild after upgrade #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removal of the package protected method getJenkinsManageOrAdmin seems to have caused JENKINS-66296, an unmarshalling error in the upgrade from git plugin 4.7.2 to git plugin 4.8.0. Restoring the package protected method seems to avoid the unmarshalling and thus avoids a problem elsewhere in the code.
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-66296 - Avoid unexpected polling rebuild after upgrade
The removal of the package protected method getJenkinsManageOrAdmin seems to have caused JENKINS-66296, an unmarshalling error in the upgrade from git plugin 4.7.2 to git plugin 4.8.0.
Restoring the package protected method seems to avoid the unmarshalling and thus avoids a problem elsewhere in the code. It is unclear to me where that problem exists or how to permanently avoid it. This change resolves the specific case described by the original submitter of the bug report and seems very low risk.
Checklist
Types of changes