Github rate limiting should always fail fast

[i386]

Requires #62 to be merged.

We see a lot of errors such as https://gist.github.com/michaelneale/d471fd6c1d44f29b94fe380ced8539d1

The Github client should always fail fast so that it never locks up web threads and cause Jenkins to become unresponsive.

PTAL @samrocketman

[samrocketman]

#62 merged

[i386]

@samrocketman rebased.

[i386]

Ahh this is failing because one of the mocks isn't setup right. Ill take a look.

[samrocketman]

Okay, I'm also troubleshooting this by trying to replicate the CI environment.

[samrocketman]

Strange, when I build with:

• Apache Maven 3.3.9
• Oracle java version "1.8.0_112"

I get a build success.

[i386]

@samrocketman OK I fixed this, rebased and squished the commit.

[i386]

Side effect of this change is that JENKINS-37581 is resolved.

[samrocketman]

Side effect is now JENKINS-37581 is resolved.

Cool I'll test that.

[samrocketman]

Unfortunately, this does not resolve JENKINS-37581.

When I attempt to log in after setting and exporting environment variables I get redirected to https://github.com/login/oauth/authorize?client_id=$GITHUB_OAUTH_CLIENTID&scope=read:org,user:email. It still literally interprets $GITHUB_OAUTH_CLIENTID.

That doesn't block me from merging this but it doesn't fix JENKINS-37581.

[samrocketman]

I tested to ensure functionality wasn't negatively affected. +2 from me.

[i386]

Ahh will have to address environment variables later.