Build is kicked off after a merge request is accepted

[jchristi]

When I accept a merge request in gitlab, it triggers another build in Jenkins. This is undesirable since the branch has already been merged and deleted. The result of the build is not useful since we've already run the build before merging the branch.

[loa]

Jenkins 1.565.2
GitLab Plugin 1.1.1
GitLab 7.2.1

Gitlab config:

• Webhook on Merge Requests Events https://jenkins/project/mergereq-behave-byoptimizer
• Gitlab CI Service https://jenkins/project/mergereq-behave-byoptimizer

Jenkins job mergereq-behave-byoptimizer

• Build on Push Events
• Build on Merge Request Events

[jchristi]

@loa does your configuration work or do you have the same issue?

My setup is:
Jenkins 1.580
GitLab Plugin 1.1.3
GitLab 7.2

[loa]

@jchristi I have the same issue.

[bassrock]

Ok it looks like what is happening, is gitlab sends a merge request event when the merge is closed. Because of this the gitlab-plugin is not filtering out the closed events. it would seem like this line: https://github.com/DABSquared/gitlab-plugin/blob/master/src/main/java/com/dabsquared/gitlabjenkins/GitLabWebHook.java#L317 Is not filtering correctly, possibly because the gitlab api changed or is not sending the right status as I have seen inconsistencies with the api vs. the documentation before.

[notFloran]

With Gitlab 7.3, I get this json : https://gist.github.com/notFloran/a5147f558465ebcec552

[xaniasd]

nice, so just adjusting the filter should do the job. Thanks!

[jchristi]

A merge request can be closed without being merged, so I assume both of these values are possible.

[xaniasd]

..but a build is not needed any longer so we can safely filter it out.

[jchristi]

In both cases it should be filtered, whether merged or closed (but not merged).

[jchristi]

@bassrock awesome, thanks :D

[peternijssen]

Good to see it's getting fixed. Had the same issue. Thanks!

[xaniasd]

Accepting a merge does not trigger a build for the merge request event anymore. However, it means that the changes are pushed to the target branch (which subsequently triggers a build). The question is, is this desirable or not? Should we also filter out this build?