Add support for Credentials plugin#59
Conversation
Based on a similar class from the HipChat plugin. Helps with migrations and credential look ups.
Deprecate old usage.
This was we can use it in Global and Job migration modes.
createHostUrl does the same thing as getBaseUrl but with a variable expansion. Rather than confuse the class with different ways of doing things we can refactor like this and simplify.
Job specific URL fails when in the pipeline syntax checker GUI.
This angers Findbugs.
|
Hi @daniel-beck this is the patch for SECURITY-839 that I didn't get time to do in March. Would you mind giving it a quick review? Also @jenkinsci/code-reviewers if anyone has time. Just some notes on this, I am looking to deprecate this plugin as the backend service (HockeyApp) is coming to its end of life so I am primarily concerned about keeping existing users happy and not breaking anything for them (or breaking as little as possible) rather than a bigger code clean up. |
|
@mezpahlan If you just want to fix the security issue we published as easily as possible, I recommend switching the type of the access token field from Nothing wrong with migrating to credentials, of course. If you still want to proceed with credentials integration, please respond and I'll give this PR a closer look. |
|
Now I feel stupid 😭. @daniel-beck Let me see how it would look like to simply migrate the |
|
Closed in favour of #60 |
2 participants
Attempt to add support for Credentials handling as the old method stored credentials in plain text.
Note: This plugin is to be deprecated soon as the HockeyApp service is going to be closed at the end of the year. So I don't particularly mind if the implementation could be better. The whole plugin is going to be re-written anyway.
I have attempted to provide a migration mechanism for free style jobs so am interested if that implementation works. I haven't found a way to do that for Pipeline jobs so will list some instructions on the release page after merging this.