Add cloudbees-folder to test scope#122
Merged
nfalco79 merged 1 commit intojenkinsci:masterfrom Sep 8, 2023
Merged
Conversation
Member
Author
|
Currently blocking jenkinsci/bom#2437 |
Contributor
|
Thanks for merging @nfalco79 ! Looking forward to a release so that this plugin can be included in the bill of materials. |
Member
Author
I am looking forward to it, too! |
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Aug 26, 2024
Fixes jenkinsci#2437 Special thanks to @nfalco79 for the release of jenkinsci/nodejs-plugin#122 The nodejs 1.6.2 plugin is the release.
6 tasks
basil
pushed a commit
to jenkinsci/bom
that referenced
this pull request
Aug 26, 2024
Fixes #2437 Special thanks to @nfalco79 for the release of jenkinsci/nodejs-plugin#122 The nodejs 1.6.2 plugin is the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running Plugin Compatibility Tester (PCT) against this plugin I noticed the following failure:
This PR chases away the failure by adding
cloudbees-folder(of a BOM managed version) to test scope.Testing done
Successfully ran PCT with this change on Java 21. Before this change, I got: