Update Jenkins Version and use Jenkins Bom #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Farix1337
commented
Sep 21, 2021
|
|
||
| public class BootSourceTest { | ||
| private static final FormValidation VALIDATION_REQUIRED = FormValidation.error(hudson.util.Messages.FormValidation_ValidateRequired()); | ||
| private static final FormValidation VALIDATION_REQUIRED = FormValidation.error(hudson.util.Messages._FormValidation_ValidateRequired().toString(US)); |
Author
There was a problem hiding this comment.
If running the Test jenkins.plugins.openstack.compute.slaveopts.BootSourceTest#doCheckImageIdWhenNoValueSet at a machine without US or GB localisation the assertion will fail, because the created VALIDATION_REQUIRED which is used for the expect value changes based on the jvm default java.util.Locale (See the Implementation org.jvnet.localizer.ResourceBundleHolder#format)
This change forces the US Localisation for the creation of the expected value of VALIDATION_REQUIRED.
- update org.jenkins-ci:acceptance-test-harness to 1.101 - update openstack4j to 3.10 - fix jackson version to avoid dependency enforce conflict of openstack4j and configuration as code - specify test-harness version via jenkins-test-harness.version from the parent pom - move jackson dependencies to compile dependencies
Member
|
Merging, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #330 currently the Plugin can't be build at jenkins.io due to the enforcement of a newer jenkins version for plugins.
This Pull Request
This Pull Request replaces #329