enable when crumbs are required #22
Conversation
|
@morficus this appears to address a problem my team is currently seeing, do you think it will get merged and released soon? |
|
(and please let me know if we can help move it forward) |
|
Wayne I'm not an owner I just saw the problem and wanted to fix it. Some On Wed, May 11, 2016, 11:16 AM wayne notifications@github.com wrote:
|
|
Can this we get this checked in? thanks |
|
why have an option if crumbs are needed or not? You can use the rest api to check if crumbs are needed. |
|
Wether it's an option or API determinated, this need to be merged. |
|
This seems to be option checked in Manage System but it's not check when I go back to System. |
|
I'd love to see this merged. This issue is currently causing me a world of pain within our estate (remote instance owner won't switch off CSRF protection, understandably) Also: the 'hasCrumbSupport' getter needs to be renamed to 'getHasCrumbSupport' in order for the config page to pick up the current value. |
| return this.hasBuildTokenRootSupport; | ||
| } | ||
|
|
||
| public boolean hasCrumbSupport() { |
There was a problem hiding this comment.
This should be renamed to 'getHasCrumbSupport', otherwise the config page will not pick up the current value.
| URL buildUrl = new URL(urlString); | ||
| connection = (HttpURLConnection) buildUrl.openConnection(); | ||
|
|
||
| if(remoteServer.hasCrumbSupport() && requestType.equals("POST")){ |
There was a problem hiding this comment.
Change to use renamed 'getHasCrumbSupport' method.
|
An related test case for this PR existed, I'll close this PR |
8 participants
No description provided.