Exclude error response time#134
Merged
undera merged 13 commits intojenkinsci:masterfrom Aug 16, 2017
Merged
Conversation
added 11 commits
August 15, 2017 12:55
undera
reviewed
Aug 16, 2017
| private long getDurationAt(double percentage) { | ||
| if (percentage < 0 || percentage > 1) { | ||
| throw new IllegalArgumentException("Argument 'percentage' must be a value between 0 and 1 (inclusive)"); | ||
| if (percentage < ZERO_PERCENT || percentage > ONE_HUNDRED_PERCENT) { |
Member
There was a problem hiding this comment.
Original constant are floats up to 1, new constants are up to 100. Isnt there error?
BTW I'd suggest to keep float approach, since users might want float percentiles in the future, like 99.5 or 99.9
Collaborator
Author
There was a problem hiding this comment.
Here no errors, because i changed all input params to following double constants:
- ZERO_PERCENT=0
- NINETY_PERCENT=90
- FIFTY_PERCENT=50
- ONE_HUNDRED_PERCENT=100.
This approach will allow to add other percentiles
added 2 commits
August 16, 2017 12:44
Because a new method is used to calculate time values in UriReport
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 67.59% 67.65% +0.06%
==========================================
Files 43 43
Lines 3715 3763 +48
Branches 640 650 +10
==========================================
+ Hits 2511 2546 +35
- Misses 995 1003 +8
- Partials 209 214 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.