Skip to content

Conversation

@CiliaFred
Copy link

Add last build option

@paul8620 paul8620 self-assigned this Sep 19, 2017
@paul8620
Copy link
Contributor

This code doesn't compile
[ERROR] public List<WorkflowJob> filterJobs(List<WorkflowJob> jobs, Pattern r) { [ERROR] ^ [ERROR] /Users/paul/jenkins/pipeline-aggregator-view-plugin/src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java:196: error: ';' expected [ERROR] public List<WorkflowJob> filterJobs(List<WorkflowJob> jobs, Pattern r) { [ERROR] ^ [ERROR] /Users/paul/jenkins/pipeline-aggregator-view-plugin/src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java:196: error: ';' expected [ERROR] public List<WorkflowJob> filterJobs(List<WorkflowJob> jobs, Pattern r) { [ERROR] ^ [ERROR] /Users/paul/jenkins/pipeline-aggregator-view-plugin/src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java:196: error: not a statement [ERROR] public List<WorkflowJob> filterJobs(List<WorkflowJob> jobs, Pattern r) { [ERROR] ^ [ERROR] /Users/paul/jenkins/pipeline-aggregator-view-plugin/src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java:196: error: ';' expected [ERROR] public List<WorkflowJob> filterJobs(List<WorkflowJob> jobs, Pattern r) { [ERROR] ^ [ERROR] /Users/paul/jenkins/pipeline-aggregator-view-plugin/src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java:272: error: reached end of file while parsing [ERROR] }
a missing } might happen when you removed the formatting ? line 193 please check thx

@CiliaFred CiliaFred force-pushed the add-last-build-option branch from 190f7b8 to a840351 Compare September 19, 2017 09:39
pom.xml Outdated

<properties>
<powermock.version>1.6.6</powermock.version>
<powermock.version>1.7.3</powermock.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have updated this probably to match the jenkins test-harness one, but the upgrade removed some of the methods in the library and now the tests are failing with error
`java.lang.NoSuchMethodError: org.mockito.internal.configuration.plugins.Plugins.getInstantiatorProvider()Lorg/mockito/plugins/InstantiatorProvider;

at org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:44)
at org.powermock.api.mockito.mockmaker.PowerMockMaker.createMock(PowerMockMaker.java:50)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:33)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:59)
at org.mockito.Mockito.mock(Mockito.java:1285)
at org.mockito.Mockito.mock(Mockito.java:1163)`

@paul8620 paul8620 merged commit c66ae76 into jenkinsci:master Sep 22, 2017
@paul8620
Copy link
Contributor

Thank you very much for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants