Make severity of scanning empty files configurable

[shamlymhd]

Added a new constructor parameter errorOnEmptyFiles, default is true
If the parameter is set, log the empty files message as error. Otherwise, log it as info.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[uhafner]

Please do not checkin unrelated files. You are also not using the correct coding style.

[uhafner]

We are almost there 😄

[shamlymhd]

I have two questions. if you can please respond

1. I was only able to run the tests locally using "mvn test" but I couldn't run by right-clicking and selecting the test or selecting the test configs in IntelliJ idea. because will throw the "Error: could not open `{jenkins.addOpens}'"
2. why build is failing here?

[uhafner]

1. {jenkins.addOpens}

I think you are using an outdated version of IntelliJ. (The removed parameter JavaDoc also was an IntelliJ bug that has been fixed recently). For details see: https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.40

[shamlymhd]

ok got it thank you and please review the PR

[uhafner]

You need to fix the errors first.

[shamlymhd]

Locally maven build is successful with java 17 and all the errors are gone after updating the IntelliJ to the 2022.2 version. I don't know the cause of this error here.

[uhafner]

There is a compile error: https://github.com/jenkinsci/plugin-util-api-plugin/actions/runs/3570909394/jobs/6002310967

Can you merge with master and retry?

[uhafner]

Maybe you did not commit all changes?

[uhafner]

You did merge with your master branch, but actually you needed to merge with my master branch 😄

[shamlymhd]

Okay got it, Thank you.

[uhafner]

I updated the following 2 PRs now with your changes to see if the consumers still work. When those builds are green, then I will merge and release this plugin:

• Redesign of plugin using external coverage model code-coverage-api-plugin#512
• Use new AgentFileVisitor base class of plugin-util warnings-ng-plugin#1406

Then we can continue with the last step for https://issues.jenkins.io/browse/JENKINS-69036.

I'll comment there what to do next.