[JENKINS-28697] Aborted build is marked as FAILED#16
Merged
gschueler merged 3 commits intojenkinsci:masterfrom Mar 22, 2016
Merged
[JENKINS-28697] Aborted build is marked as FAILED#16gschueler merged 3 commits intojenkinsci:masterfrom
gschueler merged 3 commits intojenkinsci:masterfrom
Conversation
Fixed treating aborted build as SUCCESS. In addition on a build abort there is a try to abort also Rundeck job.
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Definite +1 to this PR - please merge it ASAP :P |
|
I've been bitten by this too, please merge and release |
Author
|
There were many other changes and I would need to resolve multiple conflicts... I created it ~9 months ago. @gschueler Would you merge my PR in timely manner if rebased against master? |
|
+1, please merge and release |
|
It would be great to have it merged. |
gschueler
added a commit
that referenced
this pull request
Mar 22, 2016
[JENKINS-28697] Aborted build is marked as FAILED
|
Awesome! Now we only need a new release :-) @gschueler can you please release a new version? |
|
😬 i promise i will as soon as I can! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix treating aborted build as SUCCESS (JENKINS-28697). In addition on a build abort there is a try to abort also Rundeck job.
There are some other cases (like aborting a build not while sleeping) which could be better covered, but I don't know Jenkins API good enough.
Unfortunately the new feature has no tests, but I had problems forcing the tests infrastructure to simulate an aborted build.