Skip to content

Refresh plugin for November 2024 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtughan merged 6 commits into from
Nov 22, 2024
Merged

Refresh plugin for November 2024 #127

mtughan merged 6 commits into from
Nov 22, 2024

Conversation

@mtughan
Copy link
Contributor

@mtughan mtughan commented Nov 20, 2024 •
edited
Loading

Refresh the plugin to remove many code smells and deprecations.

  • Upgrade to Jenkins 2.479.1 and Jakarta EE 9
  • Enable Spotless checks
  • Migrate from java.io.File to java.nio
  • Migrate from JUnit 4 to JUnit 5
  • Fix usage of many deprecated methods and fields
  • Use Java 11/17 APIs to clean up code where possible
  • Fix SonarLint warnings where appropriate
  • Replace instances of master and slave.

Testing done

  • Unit tests
  • Tested extensively on my local computer

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mtughan mtughan self-assigned this Nov 20, 2024
@mtughan mtughan force-pushed the java-17-migration branch 4 times, most recently from 7e010d8 to 998b817 Compare November 20, 2024 21:08
@mtughan mtughan force-pushed the java-17-migration branch 5 times, most recently from b3e3723 to dd91016 Compare November 22, 2024 15:31
@mtughan
Fix many issues
4c94ed4
@mtughan
Remove injection
205946d 
The `GitScriptlerRepository` and `GitScriptlerRepositorySSHAccess`
classes used injection to receive objects of the given type. Switch from
injection to dynamic lookup using `ExtensionList`.
@mtughan
Add sidebar to Git Repo page
8c68a76 
Also bring the commit log back, as we have a way to limit the commits
shown now.
@mtughan mtughan marked this pull request as ready for review November 22, 2024 16:02
@mtughan mtughan merged commit 22a9c44 into jenkinsci:main Nov 22, 2024
16 checks passed
@mtughan mtughan deleted the java-17-migration branch November 22, 2024 16:03
@mtughan mtughan mentioned this pull request Nov 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basil basil basil left review comments

Assignees

@mtughan mtughan

Labels

breaking chore dependencies enhancement internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtughan @basil