[FIXED JENKINS-31192] Fix HTTPS SSL client certificate authentication#145
Closed
ymartin59 wants to merge 4 commits intojenkinsci:masterfrom
Closed
[FIXED JENKINS-31192] Fix HTTPS SSL client certificate authentication#145ymartin59 wants to merge 4 commits intojenkinsci:masterfrom
ymartin59 wants to merge 4 commits intojenkinsci:masterfrom
Conversation
Take benefits of new SVNKit SVNSSLAuthentication methods to properly support byte array PKCS#12 certificate usage. Resolves: JENKINS-31192
Contributor
Author
|
@recena Here it is. My job using client certificate authentication runs properly on my test environment. By the way, there is still a lot of job to switch from deprecated constructors to "newInstance" factory methods available in whole SVNAuthentication class hierarchy. |
This was referenced Nov 6, 2015
Contributor
|
@ymartin59 Looks great! |
Contributor
|
@ymartin59 By the way, What SVN Server are you using? |
Contributor
There was a problem hiding this comment.
@ymartin59 Please, remove this file. I uploaded by mistake.
Contributor
|
@ymartin59 Why did you close this PR? |
Contributor
Author
|
I am "experimenting" GitHub. I have just delete the source branch to create a new one with same name. I have not expected GitHub to close PR but it sounds reasonable. Here is another one with cleaner history: #146 |
Contributor
|
@ymartin59 Please, try to recover this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-31192
Take benefits of new SVNKit 1.8.11 SVNSSLAuthentication methods to properly support byte array PKCS#12 certificate usage.
Supersede #141