Disposer.requiresWorkspace is final

[jglick]

#123 mistakenly kept an override of Disposer.requiresWorkspace, which in the ultimate version of the API was not necessary (this method need only be overridden in SimpleBuildWrapper), and is in fact final. Because of reflection, this mistake was not noticed until PCT uncovered it in jenkinsci/bom#339.

[Zastai]

Not sure it makes sense to do this without also changing the other TODOs related to 2.258, but I have nothing against it either.

[Zastai]

Looks like with this change, the test fails on Jenkins < 2.258 (not unexpected) because SimpleBuildWrapper always requires a workspace there.

[jglick]

A follow up can bump the baseline to 2.263 and delete reflection, but I thought I would file the minimal patch needed for PCT.

[jglick]

the test fails on Jenkins < 2.258

Hmm because of

workflow-basic-steps-plugin/src/main/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStep.java

Line 230 in af19950

final Method requiresWorkspace = this.disposer.getClass().getMethod("requiresWorkspace");

. So the attempt to make this system usable by plugins with an older core dep never actually worked.

[jglick]

Time to get rid of reflection. I am just going to update the baseline already.

[Zastai]

LGTM

[dwnusbaum]

ReadWriteFileStepTest.testBinaryFileRoundtrip failed on Windows with CompositeIOException: Unable to delete 'C:\Users\jenkins\Work\workspace\rkflow-basic-steps-plugin_PR-134\target\tmp\j h6257972212631507846'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts., will try rebuilding.