Remove usages of deprecated APIs#94
Merged
dwnusbaum merged 3 commits intojenkinsci:masterfrom Aug 2, 2019
Merged
Conversation
car-roll
approved these changes
Jul 22, 2019
jglick
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While perusing the source tree, I noticed a number of deprecated methods:
User.get(java.lang.String)states: "This method is deprecated, because it causes unexpectedUsercreation by API usage code and causes performance degradation of used to retrieve users by ID. UsegetById(java.lang.String, boolean)when you know you have an ID."ACL.impersonate(org.acegisecurity.Authentication, java.lang.Runnable)states: "use try with resources andas(Authentication)".Jenkins.getInstance()states: "This is a historical alias forgetInstanceOrNull()but with ambiguous nullability. Useget()in typical cases."Accordingly, I replaced any calls to
User.get(java.lang.Stringwith calls toUser.getById(java.lang.String, boolean, I replaced any usages ofACL.impersonatewith usages of try-with-resources andACL.as, and I replaced any usages ofJenkins.getInstance()with usages ofJenkinsRule.jenkins.