Fix for issue JENKINS-20037 #36

Merged
merged 1 commit into from Oct 30, 2013

Conversation

Projects
None yet
3 participants
@waltflanagan
Member

waltflanagan commented Oct 28, 2013

https://issues.jenkins-ci.org/browse/JENKINS-20037

A performance regression was introduced by 46f1770 which cause a reduction in performance by an order of magnitude (4 min builds taking 40 min).

This pull reverts that change and brings build back to previous performance levels.

46f1770 should be re-examined to find a better way of accomplishing its goal without such a drastic impact on performance of the plugin.

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder Oct 28, 2013

plugins » xcode-plugin #30 SUCCESS
This pull request looks good

plugins » xcode-plugin #30 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Show comment Hide comment
@jenkinsadmin

jenkinsadmin Oct 29, 2013

Owner

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Owner

jenkinsadmin commented Oct 29, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder Oct 30, 2013

plugins » xcode-plugin #31 SUCCESS
This pull request looks good

plugins » xcode-plugin #31 SUCCESS
This pull request looks good

Revert 46f1770 to address a huge performance regression. [FIXED JENKI…
…NS-20037]


46f1770 caused the regression in performance seen this issue: https://issues.jenkins-ci.org/browse/JENKINS-20037

Reverting to use the more conservative .matches reduces parse time back to a reasonable level.
@cloudbees-pull-request-builder

This comment has been minimized.

Show comment Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder Oct 30, 2013

plugins » xcode-plugin #32 SUCCESS
This pull request looks good

plugins » xcode-plugin #32 SUCCESS
This pull request looks good

waltflanagan added a commit that referenced this pull request Oct 30, 2013

@waltflanagan waltflanagan merged commit 151afdc into jenkinsci:master Oct 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment