only call avgtool if checkbox is selected#46
Conversation
…se the values in the IPA
|
plugins » xcode-plugin #55 SUCCESS |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the set version checkbox is selected, data enters, then uncheck, the plugin still updates Info.plist. Also when the IPA is created and the version checkbox is selected, but only one field is set, the second value is considered to be blank and excluded from the file name.
This fix checks the boolean before calling the avgtool and always use the Info.plist values creating the ipa name.
See JENKINS-21387 for an example.