fix: exit Makefile gracefully if an inactive venv was found#345
Merged
jenstroeger merged 2 commits intostagingfrom Oct 28, 2022
Merged
fix: exit Makefile gracefully if an inactive venv was found#345jenstroeger merged 2 commits intostagingfrom
jenstroeger merged 2 commits intostagingfrom
Conversation
behnazh
reviewed
Oct 27, 2022
| echo "Found an activated Python virtual environment, exiting" && exit 1; \ | ||
| fi | ||
| if [ -d .venv/ ]; then \ | ||
| echo "Found an inactive Python virtual environment, please activate" && exit 1; \ |
Collaborator
There was a problem hiding this comment.
It might be good to ask to "Remove it otherwise."?
Owner
Author
There was a problem hiding this comment.
You mean as part of the echo?
behnazh
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might happen that a user runs
in which case we want to exit gracefully instead of installing a new venv over the existing one.