fix: determine an activated venv correctly when running make#346
Merged
jenstroeger merged 1 commit intostagingfrom Oct 28, 2022
Merged
fix: determine an activated venv correctly when running make#346jenstroeger merged 1 commit intostagingfrom
jenstroeger merged 1 commit intostagingfrom
Conversation
behnazh
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like here
python-package-template/Makefile
Lines 36 to 37 in 2adf30a
we want to make sure we determine an activated virtual env correctly by its environment variable, not whether a path & file exists (which is no indicator as to if the venv was actually activated).