fix: run pytest hook on unstaged files#347
Merged
jenstroeger merged 2 commits intostagingfrom Oct 28, 2022
Merged
Conversation
a472081 to
32722b2
Compare
behnazh
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that all
make checkvariants run theirpre-commithooks on unstaged files by using the--all-filescommand line option:python-package-template/Makefile
Lines 157 to 166 in f41b0e6
However, running
make testdoes not specify that optionpython-package-template/Makefile
Lines 170 to 171 in f41b0e6
and thus stashes changes before running:
This change uses the
--filescommand line option (which is similar to the--all-files) and nowmake testno longer stashes changes before running.