Skip to content

fix: determine package version even in deactivated venv #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenstroeger merged 3 commits into from
Nov 26, 2022
Merged

fix: determine package version even in deactivated venv #387

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b598729
fix: determine package version even in deactivated venv
jenstroeger Nov 17, 2022
c9a8a3b
fix: error out if package version can not be determined
jenstroeger Nov 17, 2022
66d2e0d
fix: just read the package version and fail in Python, not the Makefile
jenstroeger Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ SHELL := bash

# Set the package's name and version for use throughout the Makefile.
PACKAGE_NAME := package
ifeq ($(origin VIRTUAL_ENV),undefined)
PACKAGE_VERSION := unknown
else
PACKAGE_VERSION := $(shell python -c 'import $(PACKAGE_NAME); print($(PACKAGE_NAME).__version__)')
endif
PACKAGE_VERSION := $(shell python -c $$'try: import $(PACKAGE_NAME); print($(PACKAGE_NAME).__version__);\nexcept: print("unknown");')

# This variable contains the first goal that matches any of the listed goals
# here, else it contains an empty string. The net effect is to filter out
Expand Down