Skip to content

feat: add support for Python 3.12#632

Merged
jenstroeger merged 2 commits intostagingfrom
add-py312
May 14, 2024
Merged

feat: add support for Python 3.12#632
jenstroeger merged 2 commits intostagingfrom
add-py312

Conversation

@jenstroeger
Copy link
Copy Markdown
Owner

@behnazh I’ve not yet dropped support for Python 3.10 because we’re using it in other projects.

Also, I noticed that Dependabot — when checking for package updates — doesn’t consider the Python version? What if a package dropped support for some Python version or has not yet added support for 3.12?

@jenstroeger jenstroeger requested a review from behnazh as a code owner October 25, 2023 19:00
@behnazh
Copy link
Copy Markdown
Collaborator

behnazh commented Oct 25, 2023

I’ve not yet dropped support for Python 3.10 because we’re using it in other projects.

No, I'm already using Python 3.11. Let's update to Python 3.12.

Also, I noticed that Dependabot — when checking for package updates — doesn’t consider the Python version? What if a package dropped support for some Python version or has not yet added support for 3.12?

I think the best we can do is to rely on the tests passing after the update.

@jenstroeger
Copy link
Copy Markdown
Owner Author

No, I'm already using Python 3.11. Let's update to Python 3.12.

This change makes the package default to Python 3.12. Are you suggesting to drop support for Python 3.10 completely?

I think the best we can do is to rely on the tests passing after the update.

Fairnuff.

Also, I can now reproduce the 3.12 check failures locally and will look into it… Might be that some packages haven’t caught up quite yet 🤔

@behnazh
Copy link
Copy Markdown
Collaborator

behnazh commented Oct 26, 2023

This change makes the package default to Python 3.12. Are you suggesting to drop support for Python 3.10 completely?

Yes, I'm fine with that.

@jenstroeger
Copy link
Copy Markdown
Owner Author

@behnazh and now there’s pre-release of 3.13… Separate PR?

@behnazh
Copy link
Copy Markdown
Collaborator

behnazh commented May 14, 2024

@behnazh and now there’s pre-release of 3.13… Separate PR?

Shall we wait for the official release?

@jenstroeger jenstroeger merged commit f70fd7c into staging May 14, 2024
@jenstroeger jenstroeger deleted the add-py312 branch September 4, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants