Skip to content

chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished#669

Merged
jenstroeger merged 2 commits intostagingfrom
dont-build-draft-prs
Jan 20, 2024
Merged

chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished#669
jenstroeger merged 2 commits intostagingfrom
dont-build-draft-prs

Conversation

@jenstroeger
Copy link
Copy Markdown
Owner

No description provided.

@jenstroeger jenstroeger requested a review from behnazh as a code owner December 25, 2023 05:52
Comment thread .github/workflows/_build.yaml Outdated
@behnazh
Copy link
Copy Markdown
Collaborator

behnazh commented Jan 20, 2024

I'm not sure if this is a feat PR? 🤔

@jenstroeger
Copy link
Copy Markdown
Owner Author

I'm not sure if this is a fix PR? 🤔

Are you suggesting to turn the feat(ci) into a fix(ci) here? What problem would it fix, though?

@behnazh
Copy link
Copy Markdown
Collaborator

behnazh commented Jan 20, 2024

I'm not sure if this is a fix PR? 🤔

Are you suggesting to turn the feat(ci) into a fix(ci) here? What problem would it fix, though?

I meant feat, not fix.

@jenstroeger jenstroeger changed the title feat(ci): don’t check and test and build Draft PRs because often times they’re unfinished chore(ci): add comment to skip check and test and build for Draft PRs because often times they’re unfinished Jan 20, 2024
@jenstroeger jenstroeger requested a review from behnazh January 20, 2024 08:30
@jenstroeger jenstroeger merged commit 59378e1 into staging Jan 20, 2024
@jenstroeger jenstroeger deleted the dont-build-draft-prs branch September 4, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants