Skip to content

refactor: use consistent parameter name for scope#138

Merged
remcojansen merged 1 commit into
mainfrom
fix/consistent-scope-parameter
May 20, 2026
Merged

refactor: use consistent parameter name for scope#138
remcojansen merged 1 commit into
mainfrom
fix/consistent-scope-parameter

Conversation

@remcojansen
Copy link
Copy Markdown
Collaborator

@remcojansen remcojansen commented May 10, 2026

Ensures all subcommands consistently use scope as the parameter for accepting requested scope (and not the plural form scopes that was used previously by some subcommands).

@remcojansen remcojansen force-pushed the fix/consistent-scope-parameter branch 2 times, most recently from 79f9a5f to aaaa462 Compare May 10, 2026 20:03
@jentz jentz requested a review from Copilot May 14, 2026 20:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes CLI scope flag naming by moving affected commands from --scopes to --scope while preserving deprecated --scopes handling.

Changes:

  • Renames OIDC flow config fields from Scopes to Scope.
  • Adds deprecated --scopes aliases for affected commands.
  • Updates documentation and existing tests to use --scope.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Updates run example to use --scope.
EXAMPLES.md Updates usage examples to use --scope.
oidc/authorization_code.go Renames authorization code flow config field to Scope.
oidc/client_credentials.go Renames client credentials flow config field to Scope.
oidc/token_refresh.go Renames token refresh flow config field to Scope.
cmd/authorization_code_cfg.go Adds --scope and deprecated --scopes flag handling.
cmd/client_credentials_cfg.go Adds --scope and deprecated --scopes flag handling.
cmd/token_refresh_cfg.go Adds --scope and deprecated --scopes flag handling.
cmd/scopes_flag_deprecation.go Adds shared deprecation warning/conflict detection helper.
cmd/authorization_code_cfg_test.go Updates parser tests to use --scope.
cmd/client_credentials_cfg_test.go Updates parser tests to use --scope.
cmd/token_refresh_cfg_test.go Updates parser tests to use --scope.

Comment thread cmd/scopes_flag_deprecation.go Outdated
Ensures all subcommands consistently use `scope` as the parameter for accepting requested scope (and not the plural form `scopes` that was used previously by some subcommands).
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@remcojansen remcojansen changed the title fix: use consistent parameter name for scope refactor: use consistent parameter name for scope May 19, 2026
@remcojansen remcojansen merged commit bd11603 into main May 20, 2026
9 checks passed
@remcojansen remcojansen deleted the fix/consistent-scope-parameter branch May 20, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants