Skip to content

Correct wrong urls in README.md #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2017
Merged

Correct wrong urls in README.md #606

merged 1 commit into from
Jan 26, 2017

Conversation

@rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Jan 25, 2017

No description provided.

@glistening
Copy link
Contributor

glistening commented Jan 25, 2017

Thank you for this PR. I also found a similar broken link that introduced from #597. Could you fix the wrong url in targets/nuttx-stm32f4/README.md in this PR?

#### 4. Build IoT.js for NuttX

##### Follow the instruction
* [Build-for-NuttX](../../docs/Build-for-NuttX.md)

to

#### 4. Build IoT.js for NuttX

##### Follow the instruction
* [Build-for-NuttX](../../docs/build/Build-for-NuttX.md)

Correct wrong urls in README.md
e079cb3 
IoT.js-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
@rtakacs
Copy link
Contributor Author

rtakacs commented Jan 25, 2017

@glistening Thank you for the notice. ;)

LaszloLango
LaszloLango approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glistening
glistening approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 8a4ccc0 into jerryscript-project:master Jan 26, 2017
@rtakacs rtakacs deleted the correct_urls branch January 26, 2017 11:59
@glistening glistening mentioned this pull request Jul 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

+1 more reviewer

@glistening glistening glistening approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rtakacs @glistening @LaszloLango