Skip to content

Add setjmp and longjmp functions for stm32f4-nuttx target #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2017
Merged

Add setjmp and longjmp functions for stm32f4-nuttx target #767

merged 1 commit into from
Apr 21, 2017

Conversation

@robertsipka
Copy link
Contributor

@robertsipka robertsipka commented Apr 19, 2017

No description provided.

yichoi
yichoi reviewed Apr 19, 2017
View reviewed changes
config/nuttx/stm32f4dis/app/setjmp.S
@@ -0,0 +1,65 @@
/* Copyright JS Foundation and other contributors, http://js.foundation
Copy link
Contributor

@yichoi yichoi Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file come from JerryScript ? I wonder whether we should change the license clauses or not.

@robertsipka robertsipka force-pushed the iotjs_setjmp branch 2 times, most recently from 143cf65 to 5d597d3 Compare April 19, 2017 14:05
@glistening
Copy link
Contributor

glistening commented Apr 20, 2017

@robertsipka Could you share what jerry tests are passed by this change?

@robertsipka
Copy link
Contributor Author

robertsipka commented Apr 20, 2017

The setjmp implementation fixes the syntax_fail1.js test case on stm32f4-nuttx target.

Added the setjmp and longjmp functions on jerry side fixes several tests:

Jerry common tests with setjmp (after):
    297 PASS
     10 FAIL 

Jerry common tests without setjmp (before):
    245 PASS
     13 FAIL
     49 TIMEOUT (CRASH)

Note: This measure also contains this PR, so these changes together give the results.

@rtakacs rtakacs mentioned this pull request Apr 20, 2017
Merged
@robertsipka
Add setjmp and longjmp functions for stm32f4-nuttx target
7a188f1 
IoT.js-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
glistening
glistening approved these changes Apr 21, 2017
View reviewed changes
Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi
Copy link
Contributor

yichoi commented Apr 21, 2017

LGTM

@yichoi yichoi merged commit 3ada92a into jerryscript-project:master Apr 21, 2017
@robertsipka robertsipka deleted the iotjs_setjmp branch April 21, 2017 07:17
@glistening glistening mentioned this pull request Jul 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yichoi yichoi yichoi left review comments

+1 more reviewer

@glistening glistening glistening approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertsipka @glistening @yichoi