Skip to content

Conversation

@janjongboom
Copy link
Contributor

With the newest release of mbed CLI (1.0.0) it error's when no .mbed file is present in the project root. This breaks builds for JerryScript on mbed OS 5. With this patch we create this file and builds succeed again. We cannot use mbed new because it also creates a new git repository in targets/mbedos5 folder which is not what we want.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com

/cc @thegecko @LMESTM @zherczeg @limjunsung

Fixes #1511

With the newest release of mbed CLI (1.0.0) it error's when no .mbed file is present in the project root. This breaks builds for JerryScript on mbed OS 5. With this patch we create this file and builds succeed again. We cannot use `mbed new` because it also creates a new git repository in targets/mbedos5 folder which is not what we want.

JerryScript-DCO-1.0-Signed-off-by: Jan Jongboom janjongboom@gmail.com
@LMESTM
Copy link

LMESTM commented Jan 4, 2017

working fine thx !

@thegecko
Copy link
Contributor

thegecko commented Jan 4, 2017

LGTM

1 similar comment
@zherczeg
Copy link
Member

zherczeg commented Jan 4, 2017

LGTM

@ghost
Copy link

ghost commented Jan 5, 2017

It seems to be working, but the error message still appears...

$ make getlibs

[mbed] ERROR: Could not find mbed program in current path "/Users/limjunsung/jerryscript/targets/mbedos5".
[mbed] ERROR: Change the current directory to a valid mbed program, set the current directory as an mbed program with 'mbed config root .', or use the '--global' option to set global configuration.
echo 'ROOT=.' > .mbed
mbed config root .
[mbed] . now set as default root in program "mbedos5"
mbed toolchain GCC_ARM
[mbed] GCC_ARM now set as default toolchain in program "mbedos5"
mbed target
[mbed] No default target set in program "mbedos5"
mbed deploy
[mbed] WARNING: Program "mbedos5" in "/Users/limjunsung/jerryscript/targets/mbedos5" does not use source control management.
[mbed] WARNING: To fix this you should use "mbed new ." in the root of your program.
[mbed] Adding library "mbed-os" from "https://github.com/ARMmbed/mbed-os" at rev #d5de476f74dd

@thegecko
Copy link
Contributor

thegecko commented Jan 5, 2017

Thanks for the feedback, the output you describe is as expected and is a known limitation of the mbed build system. ARMmbed/mbed-cli#283

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 8ebbfda into jerryscript-project:master Jan 5, 2017
janjongboom added a commit to ARMmbed/mbed-js-gulp that referenced this pull request Jan 10, 2017
See jerryscript-project/jerryscript#1512.

Verified against mbed-js-example and mbed-js-repl-example. My nRF52-DK broke, so I can't verify the BLE stuff...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants