Add the ability to throw an error to python debugger #2188

DanielBallaSZTE · 2018-01-31T18:06:40Z

This patch makes it possible to throw an error from the python debugger client using the throw command.

JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

zherczeg · 2018-02-02T09:43:31Z

jerry-core/vm/vm.c

                  || JERRY_CONTEXT (debugger_stop_context) == JERRY_CONTEXT (vm_top_context_p)))
          {
            jerry_debugger_breakpoint_hit (JERRY_DEBUGGER_BREAKPOINT_HIT);
+            if (JERRY_CONTEXT (debugger_flags) & JERRY_DEBUGGER_THROW_ERROR_FLAG)


I think there are multiple jerry_debugger_breakpoint_hits in the vm. What happns when the others are called and an exception is thrown?

zherczeg · 2018-02-02T09:44:21Z

jerry-core/vm/vm.c

+              ecma_string_t *string_p = ecma_get_string_from_value (to_string_value);
+              ECMA_STRING_TO_UTF8_STRING (string_p, buffer_p, buffer_size);
+              jerry_port_log (JERRY_LOG_LEVEL_ERROR, "Uncaught exception: %.*s\n", buffer_size, buffer_p);
+              ECMA_FINALIZE_UTF8_STRING (buffer_p, buffer_size);


Do we need to log this? The user sent the request after all.

I've removed the logging part.

zherczeg · 2018-02-02T09:46:05Z

jerry-debugger/jerry-client-ws.py

 JERRY_DEBUGGER_OUTPUT_RESULT = 25
 JERRY_DEBUGGER_OUTPUT_RESULT_END = 26
+JERRY_DEBUGGER_STHROW = 27
+JERRY_DEBUGGER_STHROW_END = 28


This function sends a byte, not a string. Actually only two values are allowed. What about sending a stop instead?

I've changed the function to send a 0 or 1 only to the client.

zherczeg · 2018-02-02T09:46:56Z

jerry-core/debugger/debugger.h


  JERRY_DEBUGGER_MESSAGES_IN_MAX_COUNT, /**< number of different type of input messages */
+  JERRY_DEBUGGER_THROW = 18,
+  JERRY_DEBUGGER_THROW_PART = 19,


Where is this symbol is used?

I've updated the python client, so these messages are used, when the string is sent.

DanielBallaSZTE · 2018-02-05T11:37:43Z

@zherczeg PR Updated, thanks for the review!

zherczeg · 2018-02-08T12:45:44Z

jerry-core/debugger/debugger.c

    JERRY_ASSERT (*expected_message_type_p == JERRY_DEBUGGER_EVAL_PART
-                  || *expected_message_type_p == JERRY_DEBUGGER_CLIENT_SOURCE_PART);
+                  || *expected_message_type_p == JERRY_DEBUGGER_CLIENT_SOURCE_PART
+                  || *expected_message_type_p == JERRY_DEBUGGER_THROW_PART);


swap the last two lines.

zherczeg · 2018-02-08T12:47:09Z

jerry-core/debugger/debugger.c

+      {
+        *expected_message_type_p = JERRY_DEBUGGER_THROW_PART;
+      }
+


*expected_message_type_p = (is_eval ? JERRY_DEBUGGER_EVAL_PART : JERRY_DEBUGGER_THROW_PART);

zherczeg · 2018-02-08T12:48:23Z

jerry-core/debugger/debugger.h

  JERRY_DEBUGGER_OUTPUT_RESULT_END = 26, /**< last output result data */

  JERRY_DEBUGGER_MESSAGES_OUT_MAX_COUNT, /**< number of different type of output messages by the debugger */
+  JERRY_DEBUGGER_THROW_STOP = 27, /**< sends the client the info to terminate */


comment: "signals the client that the throw is successful" ?

DanielBallaSZTE · 2018-02-12T15:20:48Z

@zherczeg I have updated the PR, thank you for the suggestions!

zherczeg · 2018-02-20T13:32:31Z

jerry-core/vm/vm.c

+          {
+            result = JERRY_CONTEXT (error_value);
+            ecma_free_value (local_err);
+            goto error;


Would this work here:

if (JERRY_CONTEXT (debugger_flags) & JERRY_DEBUGGER_THROW_ERROR_FLAG) { ecma_free_value (local_err); } else { JERRY_CONTEXT (error_value) = local_err; }

Perhaps I would rename local_err to current_error_value

zherczeg · 2018-02-20T13:35:13Z

jerry-core/debugger/debugger.c

-                          size_t eval_string_size) /**< evaluated string size */
+jerry_debugger_send_eval_or_throw (const lit_utf8_byte_t *eval_string_p, /**< evaluated string */
+                                   size_t eval_string_size, /**< evaluated string size */
+                                   bool *is_eval) /**< throw or eval call*/


Add [in,out] to the comment.

DanielBallaSZTE · 2018-03-05T10:57:51Z

@zherczeg Sorry for the late update, thank you for the review.

zherczeg · 2018-03-07T09:23:36Z

Please rebase. The debugger tests are failing at the moment.

This patch makes it possible to throw an error from the python debugger client using the `throw` command. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

DanielBallaSZTE · 2018-03-19T15:22:49Z

@zherczeg I've rebased the PR .

zherczeg

LGTM

martijnthe · 2018-03-28T12:32:21Z

tests/debugger/do_throw.js

+  print("An error will be thrown.");
+}
+
+inevitable();


Just curious: why is any code needed in this file for this test case?

Well, we could leave it empty as well.

I don't think it hurts to keep the current file.

I was just wondering... I thought perhaps it was needed to get a breakpoint opcode emitted or something.

LaszloLango

LGTM

* Add the ability to throw an error to python debugger (jerryscript-project#2188) This patch makes it possible to throw an error from the python debugger client using the `throw` command. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu * Fix typo and redundant text in the documentation. (jerryscript-project#2260) JerryScript-DCO-1.0-Signed-off-by: Daniel Vince vinced@inf.u-szeged.hu * Fix accessing the contents of a direct string (jerryscript-project#2261) In the `ecma_string_get_chars` method the contents of a direct string is accessed incorrectly. It tries to extract the magic string id from the string pointer but the direct string does not need this step. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com * Remove websocket message macros in debugger (jerryscript-project#2262) JERRY_DEBUGGER_INIT_SEND_MESSAGE JERRY_DEBUGGER_SET_SEND_MESSAGE_SIZE JERRY_DEBUGGER_SET_SEND_MESSAGE_SIZE_FROM_TYPE JerryScript-DCO-1.0-Signed-off-by: Jimmy Huang jimmy.huang@intel.com * Remove TARGET_HOST macros (jerryscript-project#2264) Remove TARGET_HOST defines from the jerry-libc module and replace with compiler provided macros. JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu * Fix bug in stringToCesu8 conversion for 0x7ff (jerryscript-project#2267) JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson geoff@linux.intel.com * Add ecma_free_all_enqueued_jobs function (jerryscript-project#2265) This function releases any remaining promise job that wasn't completed. Also added this function to `jerry_cleanup ()`, therefore it will be automatically run. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu * Improve jerry_is_feature_enabled with object availability information (jerryscript-project#2250) JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska rzsolt@inf.u-szeged.hu * Add json parse and stringify function to jerryscript c api (jerryscript-project#2243) JerryScript-DCO-1.0-Signed-off-by: Zsolt Raduska rzsolt@inf.u-szeged.hu * Simplify debugger-ws.h (jerryscript-project#2266) Remove several macros and types from it. This change simplifies the external debugger interface. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com * Add finalize_cb to jerry_context_data_manager_t (jerryscript-project#2269) This patch adds a new finalize_cb callback to jerry_context_data_manager_t. The callback is run as the very last thing in jerry_cleanup, after the VM has been torn down entirely. There was already the deinit_cb, which is run while the VM is still in the process of being torn down. The reason the deinit_cb is not always sufficient is that there may still be objects alive (because they still being referenced) that have native pointers associated with the context manager that is being deinit'ed. As a result, the free_cb's for those objects can get called *after* the associated context manager's deinit_cb is run. This makes cleanup of manager state that is depended on by the live objects impossible to do in the deinit_cb. That type of cleanup can only be done when all values have been torn down completely. JerryScript-DCO-1.0-Signed-off-by: Martijn The martijn.the@intel.com * Rework snapshot generation API. (jerryscript-project#2259) Also remove eval context support. It provides no practical advantage. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com * Implement the ES2015 version of Object.getPrototypeOf and add a test file for it (jerryscript-project#2256) JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu * Move DevTools integration code into jerry-client-ts subdir JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson geoff@linux.intel.com * Fix some things to match the new directory for TS code JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson geoff@linux.intel.com

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from efd640f to e1bdb40 Compare February 1, 2018 10:43

robertsipka mentioned this pull request Feb 2, 2018

Avoid using an unitialized variable #2194

Closed

zherczeg requested changes Feb 2, 2018

View reviewed changes

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from e1bdb40 to cfec624 Compare February 5, 2018 11:35

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch 3 times, most recently from 8dc5df5 to eee7051 Compare February 7, 2018 11:03

zherczeg requested changes Feb 8, 2018

View reviewed changes

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from eee7051 to 33f1ece Compare February 12, 2018 15:19

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch 2 times, most recently from dc56350 to 24c12e5 Compare February 14, 2018 12:04

zherczeg reviewed Feb 20, 2018

View reviewed changes

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from 24c12e5 to 948d01c Compare March 5, 2018 10:57

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from 948d01c to 4a0af3f Compare March 7, 2018 10:50

Add the ability to throw an error to python debugger

4ee1040

This patch makes it possible to throw an error from the python debugger client using the `throw` command. JerryScript-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

DanielBallaSZTE force-pushed the jerry_debugger_throw_error branch from 4a0af3f to 4ee1040 Compare March 19, 2018 13:50

zherczeg approved these changes Mar 28, 2018

View reviewed changes

martijnthe reviewed Mar 28, 2018

View reviewed changes

LaszloLango approved these changes Mar 28, 2018

View reviewed changes

LaszloLango merged commit 8af89d9 into jerryscript-project:master Mar 28, 2018

Add the ability to throw an error to python debugger #2188

Add the ability to throw an error to python debugger #2188

Uh oh!

Conversation

DanielBallaSZTE commented Jan 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielBallaSZTE commented Feb 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielBallaSZTE commented Feb 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielBallaSZTE commented Mar 5, 2018

Uh oh!

zherczeg commented Mar 7, 2018

Uh oh!

DanielBallaSZTE commented Mar 19, 2018

Uh oh!

zherczeg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LaszloLango left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants