Fix JSON.stringify #2759
Merged
Fix JSON.stringify #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a wrong check on the property types, it did not check that the property was name accessor. Also fixed a test case. JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu
rerobika
reviewed
Feb 14, 2019
Member
rerobika
left a comment
rerobika
left a comment
There was a problem hiding this comment.
Is there any test case how this issue was found? If yes, please add it to this PR.
Contributor
|
@rerobika as you see we have had a test for it already, but the assertion in the testcase was wrong. Fixing the wrong test case is good enough to me. Of course I am not against adding more tests if they test uncovered behaviour and code path. |
rerobika
added a commit
to rerobika/jerryscript
that referenced
this pull request
Feb 23, 2019
…8 string This path fixes jerryscript-project#2759. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
added a commit
to rerobika/jerryscript
that referenced
this pull request
Feb 23, 2019
…8 string This path fixes jerryscript-project#2759. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
added a commit
to rerobika/jerryscript
that referenced
this pull request
Feb 25, 2019
…8 string This path fixes jerryscript-project#2759. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a wrong check on the property types, it did not check that the
property was a named accessor. Also fixed a test case.
JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos imiklos2@inf.u-szeged.hu