Add keys, values, entires functions for typedArray #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
4839f66 to
4636181
Compare
galpeter
requested changes
Jun 25, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
4636181 to
905a472
Compare
Contributor
Author
|
Did the requested changes. |
rerobika
requested changes
Jun 25, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.inc.h
Show resolved
Hide resolved
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
rerobika
reviewed
Jun 25, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
905a472 to
3d1db0e
Compare
rerobika
requested changes
Jun 25, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
szilagyiadam
force-pushed
the
typedarray_extensions
branch
3 times, most recently
from
63d4e39 to
ae95893
Compare
rerobika
requested changes
Jul 3, 2019
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
ae95893 to
0e74041
Compare
galpeter
reviewed
Jul 5, 2019
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
0e74041 to
ef75170
Compare
Contributor
Author
|
Updated the pl. |
rerobika
requested changes
Jul 17, 2019
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
Outdated
Show resolved
Hide resolved
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
ef75170 to
6c47499
Compare
Extended the typedArray functionality based on ES2015 Co-authored-by: Tibor Dusnoki tdusnoki@inf.u-szeged.hu JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
typedarray_extensions
branch
from
6c47499 to
b094132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the typedArray functionality based on ES2015
Co-authored-by: Tibor Dusnoki tdusnoki@inf.u-szeged.hu
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu