Skip to content

Implement String startsWith/includes/endsWith#2926

Merged
akosthekiss merged 1 commit intojerryscript-project:masterfrom
Yuyupo:startsEndsIncludes
Jul 10, 2019
Merged

Implement String startsWith/includes/endsWith#2926
akosthekiss merged 1 commit intojerryscript-project:masterfrom
Yuyupo:startsEndsIncludes

Conversation

@Yuyupo
Copy link
Copy Markdown
Contributor

@Yuyupo Yuyupo commented Jun 26, 2019

Co-authored-by: Tamas Keri tkeri@inf.u-szeged.hu
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu

Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread tests/jerry/es2015/string-prototype-endswith.js Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.h Outdated
Comment thread tests/jerry/es2015/string-prototype-endswith.js
Comment thread tests/jerry/es2015/string-prototype-includes.js Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
@Yuyupo Yuyupo force-pushed the startsEndsIncludes branch from 3a076d2 to bb20279 Compare June 27, 2019 10:21
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.h Outdated
Comment thread jerry-core/lit/lit-magic-strings.ini Outdated
@Yuyupo Yuyupo force-pushed the startsEndsIncludes branch 2 times, most recently from b18c0b0 to 37a81c1 Compare June 28, 2019 08:36
@rerobika rerobika added ecma builtins Related to ECMA built-in routines ES2015 Related to ES2015 features labels Jul 2, 2019
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
@Yuyupo Yuyupo force-pushed the startsEndsIncludes branch from 37a81c1 to a959fb7 Compare July 2, 2019 09:10
Comment thread jerry-core/ecma/builtin-objects/ecma-builtin-helpers.c Outdated
Co-authored-by: Tamas Keri tkeri@inf.u-szeged.hu
JerryScript-DCO-1.0-Signed-off-by: Daniella Barsony bella@inf.u-szeged.hu
@Yuyupo Yuyupo force-pushed the startsEndsIncludes branch from a959fb7 to 6b8c999 Compare July 2, 2019 11:27
@Yuyupo
Copy link
Copy Markdown
Contributor Author

Yuyupo commented Jul 2, 2019

@rerobika @galpeter Thanks for your reviews. Updated everything accordingly.

Copy link
Copy Markdown
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akosthekiss akosthekiss merged commit d4ce20d into jerryscript-project:master Jul 10, 2019
@Yuyupo Yuyupo deleted the startsEndsIncludes branch April 8, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecma builtins Related to ECMA built-in routines ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants