Skip to content

Add iterator close support for for-of statement#3401

Merged
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:for_of_iterator_close
Jan 13, 2020
Merged

Add iterator close support for for-of statement#3401
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:for_of_iterator_close

Conversation

@rerobika
Copy link
Copy Markdown
Member

@rerobika rerobika commented Dec 2, 2019

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika rerobika added the ES2015 Related to ES2015 features label Dec 2, 2019
Comment thread tests/jerry/es2015/for-of.js Outdated
Comment thread tests/jerry/es2015/for-of.js Outdated
Comment thread jerry-core/vm/vm-stack.c Outdated
@rerobika rerobika force-pushed the for_of_iterator_close branch 3 times, most recently from 01758c0 to a4dc739 Compare December 5, 2019 09:25
@rerobika rerobika force-pushed the for_of_iterator_close branch from a4dc739 to b62363b Compare January 6, 2020 15:14
@rerobika rerobika requested a review from zherczeg January 6, 2020 15:14
@rerobika
Copy link
Copy Markdown
Member Author

rerobika commented Jan 6, 2020

@zherczeg The patch is updated, please take an other look at it.

Copy link
Copy Markdown
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes.

Comment thread jerry-core/vm/vm-stack.h Outdated
Comment thread jerry-core/vm/vm-stack.h Outdated
@rerobika rerobika force-pushed the for_of_iterator_close branch from b62363b to ff05ac6 Compare January 8, 2020 08:39
@rerobika
Copy link
Copy Markdown
Member Author

rerobika commented Jan 8, 2020

@zherczeg Thanks for the review, I've updated the patch.

@rerobika rerobika force-pushed the for_of_iterator_close branch from ff05ac6 to aea0860 Compare January 8, 2020 08:44
@rerobika rerobika requested a review from galpeter January 9, 2020 18:59
Copy link
Copy Markdown
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/jerry/es2015/for-of-iterator-close.js Outdated
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
@rerobika rerobika force-pushed the for_of_iterator_close branch from aea0860 to c3915ec Compare January 13, 2020 15:11
Copy link
Copy Markdown
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit be8ae3a into jerryscript-project:master Jan 13, 2020
@rerobika rerobika deleted the for_of_iterator_close branch June 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants