Add support for new.target#3469
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 14, 2020
Merged
Conversation
zherczeg
reviewed
Dec 19, 2019
Contributor
Author
|
I'll do another update with corrected error messages (currently only one is used). |
rerobika
reviewed
Jan 8, 2020
galpeter
force-pushed
the
nwtrgt
branch
2 times, most recently
from
731cd78 to
1f8e677
Compare
rerobika
requested changes
Jan 9, 2020
galpeter
force-pushed
the
nwtrgt
branch
2 times, most recently
from
3b23af8 to
d7b5d12
Compare
rerobika
reviewed
Jan 10, 2020
zherczeg
reviewed
Jan 13, 2020
zherczeg
requested changes
Jan 14, 2020
Notable changes:
* Extracted the pure JS/builtin and external C method invocations
into two new methods (`ecma_op_function_call_{simple, external}`).
* Updated parser/scanner to handle "new.target" correctly.
* Added JS test case.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
Contributor
Author
|
@zherczeg thanks I'v updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
into two new methods (
ecma_op_function_call_{simple, external}).