toNumber operation should handle binary and octal literals#3471
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 10, 2020
Merged
toNumber operation should handle binary and octal literals#3471rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika merged 1 commit intojerryscript-project:masterfrom
Conversation
orkvi
force-pushed
the
number1
branch
2 times, most recently
from
c3d8806 to
0416eb6
Compare
rerobika
previously requested changes
Dec 20, 2019
rerobika
changed the title
JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi orkvi@inf.u-szeged.hu
rerobika
dismissed
their stale review
I dismiss the review, since I've become a co-author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the hexadecimal converter (string to number) function to allow conversion into other bases.
JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi orkvi@inf.u-szeged.hu