Add unscopables check to ecma_op_get_value_lex_env_base#3476
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 7, 2020
Merged
Conversation
rerobika
reviewed
Dec 20, 2019
rerobika
reviewed
Jan 6, 2020
szilagyiadam
force-pushed
the
lexenv_get_blocked_check
branch
from
d7cd25d to
317fc26
Compare
rerobika
approved these changes
Jan 6, 2020
Member
rerobika
left a comment
rerobika
left a comment
There was a problem hiding this comment.
LGTM after this minor style issue.
Also added a special test case for this to symbol-unscopables.js JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
lexenv_get_blocked_check
branch
from
317fc26 to
6aff45c
Compare
Member
|
Note: The PR and the CI fail have nothing in common. The CI fail has been resolved in #3493. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a special test case for this to symbol-unscopables.js
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu