Add length check to ecma_builtin_array_prototype_object_slice#3481
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 10, 2020
pmarkee:issue-3479
Merged
Add length check to ecma_builtin_array_prototype_object_slice#3481rerobika merged 1 commit intojerryscript-project:masterfrom pmarkee:issue-3479
rerobika merged 1 commit intojerryscript-project:masterfrom
pmarkee:issue-3479
Conversation
rerobika
approved these changes
Jan 2, 2020
dbatyai
reviewed
Jan 3, 2020
pmarkee
commented
Jan 3, 2020
Contributor
Author
|
Thanks for the review @dbatyai , I have updated the PR. |
dbatyai
reviewed
Jan 8, 2020
Member
dbatyai
left a comment
dbatyai
left a comment
There was a problem hiding this comment.
The hole count of the result array should also be fixed (on line 890). We should reset it to zero by masking it.
dbatyai
reviewed
Jan 9, 2020
dbatyai
reviewed
Jan 9, 2020
Fixes #3479 JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3479
JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu