Skip to content

Introduce builtin intrinsic object to share property values between builtin objects#3490

Merged
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:arguments_object_iterator
Jan 16, 2020
Merged

Introduce builtin intrinsic object to share property values between builtin objects#3490
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:arguments_object_iterator

Conversation

@rerobika
Copy link
Copy Markdown
Member

@rerobika rerobika commented Jan 7, 2020

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika rerobika added the ES2015 Related to ES2015 features label Jan 7, 2020
Comment thread jerry-core/ecma/operations/ecma-objects-arguments.c Outdated
@rerobika rerobika force-pushed the arguments_object_iterator branch from e987356 to 31d452c Compare January 9, 2020 13:16
@rerobika
Copy link
Copy Markdown
Member Author

rerobika commented Jan 9, 2020

@zherczeg I've updated the PR, please take an other look at it.

@rerobika rerobika requested review from galpeter and zherczeg January 9, 2020 13:23
@rerobika rerobika force-pushed the arguments_object_iterator branch 3 times, most recently from 722a347 to 2be76b9 Compare January 15, 2020 11:53
@rerobika rerobika changed the title Add iterator property for arguments object Introduce builtin intrinsic object to share property values between builtin objects Jan 15, 2020
Copy link
Copy Markdown
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika force-pushed the arguments_object_iterator branch from 2be76b9 to 22e8365 Compare January 16, 2020 09:37
Comment thread jerry-core/lit/lit-magic-strings.h Outdated
…uiltin objects

Fixed:
 - Global symbol access
 - Array.prototype.values and Array.prototype[Symbol.iterator] must be the same function object

To test the new functionality arguments object Symbol.iterator property is added.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
@rerobika rerobika force-pushed the arguments_object_iterator branch from 22e8365 to 6a16b2d Compare January 16, 2020 13:11
Copy link
Copy Markdown
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit 8b41bf3 into jerryscript-project:master Jan 16, 2020
@rerobika rerobika deleted the arguments_object_iterator branch June 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants