Skip to content

Fix iterator position calculation for array patterns#3494

Merged
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:fix_issue_3455
Jan 14, 2020
Merged

Fix iterator position calculation for array patterns#3494
rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika:fix_issue_3455

Conversation

@rerobika
Copy link
Copy Markdown
Member

@rerobika rerobika commented Jan 7, 2020

This patch fixes #3455.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

@rerobika rerobika added bug Undesired behaviour parser Related to the JavaScript parser ES2015 Related to ES2015 features labels Jan 7, 2020
Comment thread jerry-core/parser/js/js-parser-expr.c Outdated
Comment thread jerry-core/parser/js/js-parser-expr.c Outdated
Comment thread jerry-core/vm/vm.c
Comment thread jerry-core/vm/vm.c
This patch fixes jerryscript-project#3455.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
@rerobika rerobika changed the title Fix array pattern initialization for chained property accesses Fix iterator position calculation for array patterns Jan 10, 2020
@rerobika
Copy link
Copy Markdown
Member Author

@galpeter Thanks for the review I've updated the PR. Please take an other look at it.

@rerobika rerobika requested a review from galpeter January 10, 2020 13:54
Copy link
Copy Markdown
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit 210b631 into jerryscript-project:master Jan 14, 2020
@rerobika rerobika deleted the fix_issue_3455 branch June 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ES2015 Related to ES2015 features parser Related to the JavaScript parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion ecma_is_value_object (iterator) in ecma_op_iterator_next

3 participants