Add option to list symbols in Object.getOwnPropertyNames()#3507
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 16, 2020
pmarkee:get-property-names
Merged
Add option to list symbols in Object.getOwnPropertyNames()#3507rerobika merged 1 commit intojerryscript-project:masterfrom pmarkee:get-property-names
rerobika merged 1 commit intojerryscript-project:masterfrom
pmarkee:get-property-names
Conversation
rerobika
reviewed
Jan 13, 2020
rerobika
requested changes
Jan 13, 2020
Contributor
Author
|
Thanks for the review @rerobika , I updated the PR. |
galpeter
reviewed
Jan 14, 2020
Contributor
galpeter
left a comment
galpeter
left a comment
There was a problem hiding this comment.
Do we have js tests for this?
Also a little refactoring of Object.getOwnPropertyNames() JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu
Contributor
Author
|
Thanks for the review @galpeter . I have added a test case including symbols to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a little refactoring of Object.getOwnPropertyNames()
JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu