Make run-test-suite.py handle crashes properly#3512
Merged
rerobika merged 1 commit intojerryscript-project:masterfrom Jan 15, 2020
Merged
Make run-test-suite.py handle crashes properly#3512rerobika merged 1 commit intojerryscript-project:masterfrom
rerobika merged 1 commit intojerryscript-project:masterfrom
Conversation
Contributor
Author
Changes: - Crashing jerry / jerry-snapshot is always "FAIL", only the 1 return code is accepted as expected fail. - "FAIL (XPASS)" string is only used if the test marked as expected fail, but the return code is 0. - Simple "FAIL" string is used if the test marked as expected fail, but the return code is not 0 or 1. (crash) JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
ossy-szeged
force-pushed
the
fix-run-test-suite
branch
from
f664826 to
ff4f1d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
only the 1 return code is accepted as expected fail.
as expected fail, but the return code is 0.
fail, but the return code is not 0 or 1. (crash)
JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu