Skip to content

Construct non-fast array in ecma_op_array_species_create#3514

Merged
rerobika merged 1 commit intojerryscript-project:masterfrom
pmarkee:issue-3506
Jan 14, 2020
Merged

Construct non-fast array in ecma_op_array_species_create#3514
rerobika merged 1 commit intojerryscript-project:masterfrom
pmarkee:issue-3506

Conversation

@pmarkee
Copy link
Copy Markdown
Contributor

@pmarkee pmarkee commented Jan 14, 2020

Fixes #3506

Fixes #3506

JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu
@pmarkee
Copy link
Copy Markdown
Contributor Author

pmarkee commented Jan 14, 2020

NOTE: a regression test cannot be added for this case, because it will timeout.

Copy link
Copy Markdown
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika added bug Undesired behaviour ES2015 Related to ES2015 features labels Jan 14, 2020
Copy link
Copy Markdown
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit c8ce7d8 into jerryscript-project:master Jan 14, 2020
@pmarkee pmarkee deleted the issue-3506 branch December 4, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion object_p != NULL in ecma_make_object_value

3 participants