Rework the Reflect.defineProperty method#3770
Merged
dbatyai merged 1 commit intojerryscript-project:masterfrom May 25, 2020
Merged
Rework the Reflect.defineProperty method#3770dbatyai merged 1 commit intojerryscript-project:masterfrom
dbatyai merged 1 commit intojerryscript-project:masterfrom
Conversation
rerobika
requested changes
May 21, 2020
szilagyiadam
force-pushed
the
proxy_define_prop_bug
branch
from
37933d5 to
5efff71
Compare
rerobika
requested changes
May 22, 2020
zherczeg
reviewed
May 25, 2020
Also a minor update to the FromPropertyDescriptor operation since in ES6 we can use a property descriptor whitout any keys JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
szilagyiadam
force-pushed
the
proxy_define_prop_bug
branch
from
5efff71 to
6cb217e
Compare
Contributor
|
It broke built-ins/Reflect/defineProperty/return-boolean.js test. Unfortunately the CI didn't notice it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a minor update to the FromPropertyDescriptor operation since in ES6 we can use a property
descriptor whitout any keys
JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu