Skip to content

Fix error handling in Reflect.defineProperty#3800

Merged
rerobika merged 1 commit intojerryscript-project:masterfrom
szilagyiadam:reflect_define_prop_bug2
May 27, 2020
Merged

Fix error handling in Reflect.defineProperty#3800
rerobika merged 1 commit intojerryscript-project:masterfrom
szilagyiadam:reflect_define_prop_bug2

Conversation

@szilagyiadam
Copy link
Copy Markdown
Contributor

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

@rerobika
Copy link
Copy Markdown
Member

This is still not perfect, please check https://travis-ci.org/github/jerryscript-project/jerryscript/jobs/691312176#L266 this failing test.

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
@szilagyiadam szilagyiadam force-pushed the reflect_define_prop_bug2 branch from c1172bb to fdb34f8 Compare May 27, 2020 12:42
@szilagyiadam szilagyiadam changed the title Release the exception in the Reflect object's defineProperty method Fix error handling in Reflect.defineProperty May 27, 2020
Copy link
Copy Markdown
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 7a20150 into jerryscript-project:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants